Cloudmin is not deleting all VPS specific data when creating new image from it

To reproduce the issue, please:

  • create a guest system assigning an IP address aa.aaa.aaa.aaa to it;
  • create a new System Image from the guest system;
  • create another guest system assigning a different IP bbb.bb.bbb.bbb. from the newly created System Image;
  • open the newly created guest system's Webmin to see:

Your system's primary IP address appears to have changed from aa.aaa.aaa.aaa to bbb.bb.bbb.bbb. Domains using the old address may be unreachable or serve the wrong web content.

Searching for all the files with the old IP aa.aaa.aaa.aaa on the new guest system I found the following files:

/etc/webmin/virtual-server/config
/etc/webmin/virtual-server/last-config

containing both this line:

old_defip=aa.aaa.aaa.aaa

I believe Cloudmin should remove the old IP address when creating a System Image from the existing guest systems.

Thanks for your attention.

Status: 
Closed (fixed)

Comments

Thanks for pointing this out - I will fix this in the next Cloudmin release.

Automatically closed -- issue fixed for 2 weeks with no activity.

I've found out that it doesn't also delete the content of the following directory when creating a new image:

/var/log/virtualmin/

Should've I created a new issue for this one or do you want me to report on this same page if I find other data that is left by Cloudmin when creating a new image from existing VPS?

It's not clear if /var/log/virtualmin should be deleted - on an image that has domains, it makes sense that the logs for those domains be preserved. However, if all domains have been deleted, Virtualmin should have removed their logs at domain deletion time.

In fact I had been creating image from completely emptied VPS with no domains, which had once some domains. They had been deleted correctly through Virtualmin UI, but for some reason those logs persisted to be there.

Update: Nevermind this as I've just tested on afresh install - Virtualmin removes those logs' files upon deletion of VSs.So probably something went wrong with the above case.